From bdb85b013c9e3f169bb883af69fcae01168ed842 Mon Sep 17 00:00:00 2001 From: abdullahalam123 Date: Sat, 15 Nov 2025 10:30:37 +0530 Subject: [PATCH] fix: implement clone method for DrawingOptions and remove signature mode init The clone method in DrawingOptions was previously unimplemented, now it properly creates a copy. Also removed unnecessary signature mode initialization in sign-pdf.ts as it's handled elsewhere. --- public/pdfjs-viewer/pdf.mjs | 4 +++- src/js/logic/sign-pdf.ts | 9 --------- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/public/pdfjs-viewer/pdf.mjs b/public/pdfjs-viewer/pdf.mjs index 18c32fe..997e5b0 100644 --- a/public/pdfjs-viewer/pdf.mjs +++ b/public/pdfjs-viewer/pdf.mjs @@ -21663,7 +21663,9 @@ class DrawingOptions { this.updateProperties(options); } clone() { - unreachable("Not implemented"); + const copy = new this.constructor(); + copy.updateAll(this); + return copy; } } class DrawingEditor extends AnnotationEditor { diff --git a/src/js/logic/sign-pdf.ts b/src/js/logic/sign-pdf.ts index a355151..c351317 100644 --- a/src/js/logic/sign-pdf.ts +++ b/src/js/logic/sign-pdf.ts @@ -69,15 +69,6 @@ export async function setupSignTool() { if (editorStampButton) { editorStampButton.disabled = false; } - - // Ensure annotation editor is fully enabled; start in Signature mode - const pdfViewer = app.pdfViewer; - const AnnotationEditorType = viewerWindow.pdfjsLib?.AnnotationEditorType; - if (pdfViewer && AnnotationEditorType) { - pdfViewer.annotationEditorMode = { - mode: AnnotationEditorType.SIGNATURE, - }; - } } } catch (e) { console.error('Could not initialize base PDF.js viewer for signing:', e);